[Webkit-unassigned] [Bug 87774] REGRESSION (r105515): reflection masks are truncated at zoom levels < 1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 1 12:52:57 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=87774
--- Comment #6 from Tim Horton <timothy_horton at apple.com> 2012-06-01 12:52:56 PST ---
(From update of attachment 145361)
View in context: https://bugs.webkit.org/attachment.cgi?id=145361&action=review
> Source/WebCore/ChangeLog:17
> + * rendering/RenderBoxModelObject.cpp:
Additional newline here.
> Source/WebCore/rendering/RenderBoxModelObject.cpp:1034
> + IntSize imageIntrinsicSize = calculateImageIntrinsicDimensions(image, positioningAreaSize, true);
Maybe an enum instead of an incomprehensible bool argument?
> Source/WebCore/rendering/RenderBoxModelObject.cpp:1251
> - int imageWidth = imageSize.width() / style->effectiveZoom();
> - int imageHeight = imageSize.height() / style->effectiveZoom();
> + int imageWidth = imageSize.width();
> + int imageHeight = imageSize.height();
Have you quadruple checked that this doesn't break the apple.com top bar again (a la https://bugs.webkit.org/show_bug.cgi?id=76249)?
> LayoutTests/ChangeLog:5
> + -and corresponding-
I don't know that the -and corresponding- is necessary, but OK :D
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list