[Webkit-unassigned] [Bug 87800] [GTK] Add a new and reusable Geoclue-based geolocation provider in WebCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=87800


Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #145321|review?                     |review+
               Flag|                            |




--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-06-01 09:55:05 PST ---
(From update of attachment 145321)
View in context: https://bugs.webkit.org/attachment.cgi?id=145321&action=review

Please consider changing the return in geoclueClientSetRequirementsCallback before landing.

> Source/WebCore/platform/geoclue/GeolocationProviderGeoclue.cpp:66
> +    if (error) {
> +        provider->errorOccurred(error->message);
> +        g_error_free(error);
> +        return;
> +    }

This could be an early return, or remove the return, because there's nothing to do if there isn't an error

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.