[Webkit-unassigned] [Bug 84048] ShadowRoot needs resetStyleInheritance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=84048





--- Comment #42 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2012-06-01 09:26:50 PST ---
(From update of attachment 145225)
View in context: https://bugs.webkit.org/attachment.cgi?id=145225&action=review

> Source/WebCore/css/StyleResolver.cpp:1173
> +            m_parentStyle = parentStyle;
> +        else
> +            m_parentStyle = m_parentNode ? m_parentNode->renderStyle() : 0;

This can be made into inline if.

> Source/WebCore/css/StyleResolver.cpp:4925
> +    Settings* settings = m_checker.document()->settings();
> +    if (!settings)
> +        return false;

I would rather have a separate function that returns Settings*. This way, you avoid ambiguity of why initializeFontSylte returns a boolean:

if (Settings* settings = documentSettings()) {
    initializeFontStyle(settings);
...

Also might be worth looking at other callsites of document()->settings() and using this new accessor there. Looks like a good separate patch :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.