[Webkit-unassigned] [Bug 87842] [WK2-Gtk]Compilation errors with flag CONTEXT_MENUS=0

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 1 09:14:01 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=87842


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #145217|review?                     |review-
               Flag|                            |




--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2012-06-01 09:14:01 PST ---
(From update of attachment 145217)
View in context: https://bugs.webkit.org/attachment.cgi?id=145217&action=review

> Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp:28
>  #include "config.h"
> +
>  #include "WebContextMenuProxyGtk.h"

Okay, this a serious nit pick, but we don't typically put a newline here. If you were a committer, I'd just have you fix it and land yourself. I don't believe you are though, so do you mind uploading a new patch? Really appreciate it!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list