[Webkit-unassigned] [Bug 85041] [EFL][WK2] Compile webkit1 and webkit2 by default.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=85041





--- Comment #11 from Raphael Kubo da Costa (rakuco) <rakuco at webkit.org>  2012-06-01 07:17:16 PST ---
(From update of attachment 145116)
View in context: https://bugs.webkit.org/attachment.cgi?id=145116&action=review

It looks good. You need to rebase your patch, and I don't think the EWS has actually run it, as ENABLE_WEBKIT2 is still OFF in its CMakeCache.txt.

> Tools/Scripts/build-webkit:677
> +    $cmakeArgs .= ($cmakeArgs ? " " : "") . "-DENABLE_WEBKIT=On";
> +    $cmakeArgs .= " -DENABLE_WEBKIT2=On" if !$noWebKit2;

Style nit: we generally use "ON" instead of "On".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.