[Webkit-unassigned] [Bug 88071] [BlackBerry] Add end editing handling into AutofillManager

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 1 04:13:31 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=88071


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #145261|review?                     |review+
               Flag|                            |




--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2012-06-01 04:13:30 PST ---
(From update of attachment 145261)
View in context: https://bugs.webkit.org/attachment.cgi?id=145261&action=review

Looks good.

> Source/WebKit/blackberry/WebCoreSupport/AutofillManager.h:44
> +    void didEndEditing(HTMLInputElement*);

Since other methods use TextField in the name, and we call it from  EditorClientBlackBerry::textFieldDidEndEditing, you should probably add TextField in this function too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list