[Webkit-unassigned] [Bug 88049] Layout not updated after setting -webkit-line-clamp to none

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88049





--- Comment #4 from mitz at webkit.org  2012-06-01 01:18:28 PST ---
(From update of attachment 145222)
View in context: https://bugs.webkit.org/attachment.cgi?id=145222&action=review

Thanks for the review!

>> Source/WebCore/ChangeLog:14
>> +        children for layout and clears trunaction from blocks.
> 
> typo 'trunacation'

I am going to fix this.

>> Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:153
>> +void RenderDeprecatedFlexibleBox::styleWillChange(StyleDifference diff, const RenderStyle *newStyle)
> 
> * on the wrong side.

Oops! I will fix this.

>> Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:995
>> +            || (child->style()->height().isAuto() && child->isBlockFlow())) {
> 
> Do we want to use logicalHeight here ?

I don’t think RenderDeprecatedFlexibleBox was ever made writing-mode aware. More importantly, this code follows the logic in applyLineClamp().

>> Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:996
>> +            child->setChildNeedsLayout(true);
> 
> I think we just need to MarkOnlyThis in the second argument.

MarkOnlyThis is only useful during layout, when you don’t want to re-dirty the ancestors. clearLineClamp() is not called during layout, so MarkOnlyThis is not necessary and using it would introduce risk of creating a subtree that needs layout and never gets it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.