[Webkit-unassigned] [Bug 73176] Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 1 00:58:47 PDT 2012


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #144730|review?, commit-queue?      |review-
               Flag|                            |

--- Comment #44 from Adam Barth <abarth at webkit.org>  2012-06-01 00:58:43 PST ---
(From update of attachment 144730)
View in context: https://bugs.webkit.org/attachment.cgi?id=144730&action=review

This patch looks like it's in pretty good shape.  I've left you a couple minor comments below.  Once those are addressed, we should be all set.  Thanks!

> Source/WebCore/page/CustomHandlersState.cpp:7
> +    version 2.1 of the License, or (at your option) any later version.

Typically new files are licensed using BSD, but it's up to you.

> Source/WebCore/page/CustomHandlersState.cpp:27
> +String customHandlersStateString(CustomHandlersState state)

Rather than creating a whole new file for this rather simple function, you can declare the CustomHandlersState enum in ChromeClient.h and have the client method return an enum value rather than a string.  Then you can do the translation between enum values and strings in a static function in NavigatorRegisterProtocolHandler.cpp.

> Source/WebCore/page/NavigatorRegisterProtocolHandler.cpp:157
> +    if (!document)
> +        return declined;

document can never be 0 here.

> Source/WebCore/page/NavigatorRegisterProtocolHandler.cpp:182
> +    if (!document)
> +        return;


> Source/WebCore/page/NavigatorRegisterProtocolHandler.idl:27

You can just use the [Conditional] attribute on the method.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list