[Webkit-unassigned] [Bug 88049] Layout not updated after setting -webkit-line-clamp to none

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88049


Abhishek Arya <inferno at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #145222|review?                     |review+
               Flag|                            |




--- Comment #2 from Abhishek Arya <inferno at chromium.org>  2012-06-01 00:58:06 PST ---
(From update of attachment 145222)
View in context: https://bugs.webkit.org/attachment.cgi?id=145222&action=review

> Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:153
> +void RenderDeprecatedFlexibleBox::styleWillChange(StyleDifference diff, const RenderStyle *newStyle)

* on the wrong side.

> Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:987
> +void RenderDeprecatedFlexibleBox::clearLineClamp()

nit: Can this code be shared with http://code.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp&exact_package=chromium&q=markPositionedObjectsForLayout&type=cs&l=883 to avoid duplication.

> Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:995
> +            || (child->style()->height().isAuto() && child->isBlockFlow())) {

Do we want to use logicalHeight here ?

> Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:996
> +            child->setChildNeedsLayout(true);

I think we just need to MarkOnlyThis in the second argument.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.