[Webkit-unassigned] [Bug 92725] IndexedDB: ObjectStoreMetaDataKey::m_metaDataType should use byte type

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92725





--- Comment #11 from Kentaro Hara <haraken at chromium.org>  2012-07-31 23:59:57 PST ---
(From update of attachment 155729)
View in context: https://bugs.webkit.org/attachment.cgi?id=155729&action=review

LGTM. If jsbell@ says OK, I'm happy to r+ it.

> Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp:180
> +    ASSERT(p < limit);
> +    if (p >= limit)

This looks strange. We don't need both. (Although some code in IDBLevelDBCoding.cpp already use both.)

If 'p >= limit' must not happen, please remove 'if (p >= limit)'. If it can happen, please remove ASSERT(p < limit). (I think that removing ASSERT() looks reasonable in this case.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.