[Webkit-unassigned] [Bug 92725] IndexedDB: ObjectStoreMetaDataKey::m_metaDataType should use byte type

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92725


Joshua Bell <jsbell at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #155461|review-                     |review?
               Flag|                            |




--- Comment #8 from Joshua Bell <jsbell at chromium.org>  2012-07-31 20:12:42 PST ---
(From update of attachment 155461)
View in context: https://bugs.webkit.org/attachment.cgi?id=155461&action=review

You're right - the range of existing values that are used for the ObjectMetaDataType should encode identically for VarInt and Byte since they are <= 127. So this should be safe. (A webkit_unit_test case could be added for that, validating that the encodings are the same for the current roster of values.) Removing my paranoid objection.

> Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp:67
> +//     The prefix is followed by a type byte, then a variable-length integer, and then another variable-length integer.

That should end with "and then another type byte."

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.