[Webkit-unassigned] [Bug 81332] Cache support for OpenTypeVerticalData

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81332





--- Comment #43 from Koji Ishii <kojiishi at gmail.com>  2012-07-31 16:32:57 PST ---
> (From update of attachment 155164 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=155164&action=review
> 
> I think this is OK to land.
> 
> It's a bit unfortunate that it's a completely separate cache and makes FontCache.cpp more complex even though it's only going to be used on Windows, but I don't know of a better place for it.

Yeah, agreed. I actually was surprised by finding there's no cache per font file in WebKit today. I guess there will be such needs from other than vertical flow on Windows and I hope the code can be re-used in such instances.

> It would be awesome if you did a follow up patch to switch the whole file to using OwnPtrs instead of new/delete.

I entered bug 92808. I'll be working on bug 51450 first, but I'll also try to submit a patch for 92808.

> > Source/WebCore/platform/graphics/FontCache.cpp:192
> > +    const AtomicString& familyName = passedFamilyName.isEmpty() || passedFamilyName[0] != '@' ?
> 
> Nit: I would include parentheses around the the ternary condition.

Submitted updated patch that fixes this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.