[Webkit-unassigned] [Bug 81332] Cache support for OpenTypeVerticalData

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81332


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #155164|review?                     |review+
               Flag|                            |




--- Comment #40 from Tony Chang <tony at chromium.org>  2012-07-31 15:28:48 PST ---
(From update of attachment 155164)
View in context: https://bugs.webkit.org/attachment.cgi?id=155164&action=review

I think this is OK to land.

It's a bit unfortunate that it's a completely separate cache and makes FontCache.cpp more complex even though it's only going to be used on Windows, but I don't know of a better place for it.

It would be awesome if you did a follow up patch to switch the whole file to using OwnPtrs instead of new/delete.

> Source/WebCore/platform/graphics/FontCache.cpp:192
> +    const AtomicString& familyName = passedFamilyName.isEmpty() || passedFamilyName[0] != '@' ?

Nit: I would include parentheses around the the ternary condition.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.