[Webkit-unassigned] [Bug 92685] [BlackBerry] Enable CSS Filter Effects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92685


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #155589|review?                     |review-
               Flag|                            |




--- Comment #12 from Rob Buis <rwlbuis at gmail.com>  2012-07-31 11:37:30 PST ---
(From update of attachment 155589)
View in context: https://bugs.webkit.org/attachment.cgi?id=155589&action=review

> Source/WebCore/platform/graphics/blackberry/LayerFilterRenderer.h:100
> +    bool shouldPushSnapshot() { return m_pushSnapshot; }

Could be const.

> Source/WebCore/platform/graphics/blackberry/LayerFilterRenderer.h:101
> +    void setPushSnapshot() { m_pushSnapshot = 1; }

Better use true.

> Source/WebCore/platform/graphics/blackberry/LayerFilterRenderer.h:103
> +    bool shouldPopSnapshot() { return m_popSnapshot; }

Ditto.

> Source/WebCore/platform/graphics/blackberry/LayerFilterRenderer.h:104
> +    void setPopSnapshot() { m_popSnapshot = 1; }

Etcetera.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.