[Webkit-unassigned] [Bug 92685] [BlackBerry] Enable CSS Filter Effects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92685


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #155578|review?                     |review-
               Flag|                            |




--- Comment #9 from Rob Buis <rwlbuis at gmail.com>  2012-07-31 10:35:49 PST ---
(From update of attachment 155578)
View in context: https://bugs.webkit.org/attachment.cgi?id=155578&action=review

Looks good, one more iteration needed.

> Source/WebCore/platform/graphics/blackberry/LayerFilterRenderer.cpp:371
> +    for (int i = 0;i < LayerData::NumberOfCSSFilterShaders; ++i)

Add a space after i = 0;

> Source/WebCore/platform/graphics/blackberry/LayerFilterRenderer.h:98
> +        // see the ping-pong note in LayerFilterRenderer::applyActions

Not completely WebKit style comments.

> Source/WebCore/platform/graphics/blackberry/LayerWebKitThread.h:102
> +    void setFilters(const FilterOperations& filters) { m_filters = filters; m_filtersChanged = 1; setNeedsCommit(); }

Inconsistent use of m_filtersChanged, setting to 1 and false.

> ChangeLog:11
> +        * Source/cmakeconfig.h.cmake: Acknowldge CSS filter effects

Typo Acknowldge

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.