[Webkit-unassigned] [Bug 92725] IndexedDB: ObjectStoreMetaDataKey::m_metaDataType should use byte type

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92725





--- Comment #6 from David Grogan <dgrogan at chromium.org>  2012-07-31 09:54:18 PST ---
(From update of attachment 155461)
View in context: https://bugs.webkit.org/attachment.cgi?id=155461&action=review

>>> Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp:1089
>>> +    result->m_metaDataType = *p++;
>> 
>> Shall we implement decodeByte()? (For consistency with existing encodeByte().)
> 
> Good suggestion.

For compatibility with existing databases, you can maybe detect here whether it's a byte or var int.  I don't know if that's bulletproof though.  Or you can look into doing a schema upgrade in IDBLevelDBBackingStore::setUpMetadata.  That might be slow.  Some experimentation might be needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.