[Webkit-unassigned] [Bug 92729] code parameter of WebSocket::close() should be unsigned value than signed.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 31 07:31:29 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=92729





--- Comment #5 from Takashi Toyoshima <toyoshim at chromium.org>  2012-07-31 07:31:30 PST ---
How about following idea?

- move WebSocket::close implementation to WebSocket::close(bool, int, const String&, ExceptionCode&). This implementation accept four arguments, and the first bool indicates if code and reason are passed.
- all three close bindings use this four argument version close.
- keep CloseEventCodeNotSpecified being -1, and keep WebSocketChannel::close accepting int value for code argument.
- also keep WebKit API as is.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list