[Webkit-unassigned] [Bug 91632] Web Inspector: extracting HighlightInfo from HighlightData in DOMNodeHighlighter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91632


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #155462|review?                     |review-
               Flag|                            |




--- Comment #9 from Pavel Feldman <pfeldman at chromium.org>  2012-07-31 06:43:39 PST ---
(From update of attachment 155462)
View in context: https://bugs.webkit.org/attachment.cgi?id=155462&action=review

Looks mostly good, few nits inline.

> Source/WebCore/inspector/DOMNodeHighlighter.h:60
> +struct HighlightData {

1) I don't think you need highlight data type.
2) I think it is fine to have rect and node assigned at the same time

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1016
> +    if (!highlightInspectorObject)

This should never happen, you should return ErrorString for such cases,

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1021
> +    highlightInspectorObject->getBoolean("showInfo", &showInfo);

I believe we are generating constants for these.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.