[Webkit-unassigned] [Bug 92729] New: code parameter of WebSocket::close() should be unsigned value than signed.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92729

           Summary: code parameter of WebSocket::close() should be
                    unsigned value than signed.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
               URL: http://www.whatwg.org/specs/web-apps/current-work/mult
                    ipage/network.html#websocket
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rgf748 at motorola.com


This has came up with discussion from Bug92642.

Currently as per the WebSocket API spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/network.html#websocket
The first parameter(code) of the close() api should be unsigned value but currently it is signed value.

Replacing this code value to unsigned and WebSocketChannel::CloseEventCodeNotSpecified to 0 we can tweak idl definition as

void close(in [Clamp, Optional=DefaultIsUndefined] unsigned short code, in [Optional=DefaultIsNullString] DOMString reason) raises(DOMException);

Also below extra defiantions of close() from WebSocket.h can be removed.

void close(ExceptionCode& ec) { close(WebSocketChannel::CloseEventCodeNotSpecified, String(), ec); }
void close(int code, ExceptionCode& ec) { close(code, String(), ec); }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.