[Webkit-unassigned] [Bug 91688] [chromium] Add CCScrollbarAnimationController class for compositor scrollbar animation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 30 15:14:01 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=91688


Adrienne Walker <enne at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #155376|review?                     |review-
               Flag|                            |




--- Comment #16 from Adrienne Walker <enne at google.com>  2012-07-30 15:14:01 PST ---
(From update of attachment 155376)
View in context: https://bugs.webkit.org/attachment.cgi?id=155376&action=review

> Source/WebCore/page/FrameView.cpp:655
> +// On Android (and potentially other platform that supports pinch zoom)
> +// the main frame should always create scrollbars unless hidden explicitly,
> +// as the viewport size can change in the compositor
> +#if OS(ANDROID)
> +    if (m_frame->page()->mainFrame() == m_frame) {
> +        if (hMode == ScrollbarAuto)
> +            hMode = ScrollbarAlwaysOn;
> +        if (vMode == ScrollbarAuto)
> +            vMode = ScrollbarAlwaysOn;
> +    }
> +#endif

I thought this was going into a separate patch?

> Source/WebCore/rendering/RenderLayer.cpp:2961
> -    if (!isSelfPaintingLayer() && !hasSelfPaintingLayerDescendant())
> +    if (!isSelfPaintingLayer() && !hasSelfPaintingLayerDescendant() && !(paintFlags & PaintLayerPaintingOverlayScrollbars))

Where did all these RenderLayer changes come from in this latest patch?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list