[Webkit-unassigned] [Bug 92040] Delete text from password does nothing, proposed fix

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92040


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #154286|review?                     |review-
               Flag|                            |




--- Comment #12 from Ryosuke Niwa <rniwa at webkit.org>  2012-07-30 11:53:17 PST ---
(From update of attachment 154286)
View in context: https://bugs.webkit.org/attachment.cgi?id=154286&action=review

> Source/WebCore/editing/EditorCommand.cpp:1239
> +        // Special handling for password fields: Webkit bug 92040
> +        if (frame->selection()->isInPasswordField())
> +            return frame->selection()->isRange() && enabledInEditableText(frame, event, source) && frame->selection()->isContentEditable();

We shouldn't be duplicating a code in enabledCut. I think all we need to do is to call Editor::canDelete() regardless of whether we're in a password field or not.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.