[Webkit-unassigned] [Bug 88376] Incorrect rect-based hit-test result when hit-test region includes culled inlines

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88376





--- Comment #4 from Raymes Khoury <raymes at google.com>  2012-07-30 08:20:52 PST ---

> How could it fall completely outside? Since we are moving up the tree, shouldn't the objects just get larger. If we were moving down or sideways I could see how some of them might be floating or positioned, but going up, they should be positioned the same as their children (at least within the same inline context). 

This is not strictly true AFAIK. See https://bugs.webkit.org/show_bug.cgi?id=85849#c22 for a simple example.

> 
> I am also confused why we are not checking siblings. Couldn't we end up missing culled nodes where we don't intersect their children, but we do intersect the culled node? It is the potential need to check siblings that I see as the biggest reason to change the logic itself. The other cases should be solvable by just improving your "hack" :)

I think that is true, though best to write a test to check. There is some weird stuff that happens with culled inlines so it might not necessarily be true (in particular, doing a point-based hit-test on a culled node seems to work properly). I definitely agree that I don't think the hack can just be improved to fix the problem. There are several subtle cases that I would be worried about.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.