[Webkit-unassigned] [Bug 89692] Web Inspector: show worker started and finished on timeline

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89692





--- Comment #34 from Rob Buis <rwlbuis at gmail.com>  2012-07-30 07:10:54 PST ---
(From update of attachment 155049)
View in context: https://bugs.webkit.org/attachment.cgi?id=155049&action=review

Looks good in general.

> Source/WebCore/inspector/InspectorInstrumentation.cpp:978
> +        timelineAgent->didStartWorker(id, url);

How about more early return style here?
InspectorWorkerAgent* workerAgent = instrumentingAgents->inspectorWorkerAgent();
if (!workerAgent)
    return;

int id = workerAgent->didStartWorkerContext(workerContextProxy, url);
if (!id)
    return;

if (InspectorTimelineAgent* timelineAgent = instrumentingAgents->inspectorTimelineAgent())
    timelineAgent->didStartWorker(id, url);

> Source/WebCore/inspector/InspectorInstrumentation.cpp:1002
> +        timelineAgent->didTerminateWorker(id);

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.