[Webkit-unassigned] [Bug 90670] Vertically center non-anchored <dialog> elements

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90670





--- Comment #5 from Matt Falkenhagen <falken at chromium.org>  2012-07-30 03:58:12 PST ---
I'm trying now to implement what the spec says. This means adding special handling to layout for positioning dialog elements.

My thinking is it should probably follow much the same code path as for fixed elements, since we want to position the dialog in terms of the viewport. 
So my approach is to try to get the fixed positioning code to also handle dialog. For example, change RenderLayer::updateLayerPositionsAfterScroll to cause repaint rects to be computed for dialog as well as fixed elements. This involves changing some conditionals to be like (position() == FixedPosition || isDialog()), which may be a little ugly.

Now I've gotten RenderView::computeRectForRepaint and RenderView::mapLocalToContainer to be called for dialog as if it were a fixed element, but this is not sufficient for a working implementation.

Any thoughts on this approach? Perhaps dialog should be laid out independently of fixed elements instead?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.