[Webkit-unassigned] [Bug 92342] Web Inspector [JSC]: Support multi instance for PageScriptDebugServer of JSC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92342





--- Comment #19 from Peter Wang <peter.wang at torchmobile.com.cn>  2012-07-30 00:29:59 PST ---
(In reply to comment #18)
> (From update of attachment 155200 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=155200&action=review
> 
> > Source/WebCore/bindings/js/PageScriptDebugServer.cpp:64
> > +PageScriptDebugServer& PageScriptDebugServer::server(Page* page)
> 
> Remove this method as PageScriptDebugServer::instance does the same things.

Ok. Maybe I can remove "instance()", "server()" is left for invoked by high level invoking like PageDebugAgent::scriptDebugServer since V8 has the same interface.

> > Source/WebCore/bindings/js/PageScriptDebugServer.cpp:161
> > +    ASSERT(page && page == m_page);
> 
> What about the comment above about page being null in some cases?

In ideal situation, if PageScriptDebugServer exists, the "m_page" shouldn't be null and the "page" read by ScriptDebugServer from callFrame should be same.
But if there is some accident takes place in released version, I want PageScriptDebugServer to do nothing just return.
Do you think it's appropriate?  

> > Source/WebCore/bindings/js/PageScriptDebugServer.h:53
> > +    static void addListener(ScriptDebugListener*, Page*);
> 
> add/removeListener can be instance methods and we could keep the list of listeners on a corresponding PageScriptDebugServer, no need to have additional static map.
Yes, thanks. Now for JSC:：PageScriptDebugServer the argument "Page" can also be ignored.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.