[Webkit-unassigned] [Bug 92342] Web Inspector [JSC]: Support multi instance for PageScriptDebugServer of JSC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92342


Yury Semikhatsky <yurys at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #155200|1                           |0
        is obsolete|                            |




--- Comment #18 from Yury Semikhatsky <yurys at chromium.org>  2012-07-29 23:51:16 PST ---
(From update of attachment 155200)
View in context: https://bugs.webkit.org/attachment.cgi?id=155200&action=review

> Source/WebCore/bindings/js/PageScriptDebugServer.cpp:64
> +PageScriptDebugServer& PageScriptDebugServer::server(Page* page)

Remove this method as PageScriptDebugServer::instance does the same things.

> Source/WebCore/bindings/js/PageScriptDebugServer.cpp:161
> +    ASSERT(page && page == m_page);

What about the comment above about page being null in some cases?

> Source/WebCore/bindings/js/PageScriptDebugServer.h:53
> +    static void addListener(ScriptDebugListener*, Page*);

add/removeListener can be instance methods and we could keep the list of listeners on a corresponding PageScriptDebugServer, no need to have additional static map.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.