[Webkit-unassigned] [Bug 81967] lots of cookied crashes when running nrwt -2 on mac lion, no webprocess crash logs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81967


Glenn Adams <glenn at skynav.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |glenn at skynav.com




--- Comment #9 from Glenn Adams <glenn at skynav.com>  2012-07-28 15:39:37 PST ---
not sure if it is related to this WKB, but I'm noticing failures to read crash_logs on mac-lion with the following errors, which match current output from buildbot [1] (see tail of file):

[1] http://build.webkit.org/builders/Apple%20Lion%20Debug%20WK2%20%28Tests%29/builds/1907/steps/layout-test/logs/stdio

15:25:02.475 73067 looking for crash log for WebProcess:73112

TypeError raised: coercing to Unicode: need string or buffer, tuple found
15:25:02.597 73067     File "/Volumes/Data/slave/lion-debug-tests-wk2/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 115, in run
15:25:02.598 73067       unexpected_result_count = manager.run(args)
15:25:02.598 73067     File "/Volumes/Data/slave/lion-debug-tests-wk2/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 881, in run
15:25:02.598 73067       self._look_for_new_crash_logs(result_summary, start_time)
15:25:02.598 73067     File "/Volumes/Data/slave/lion-debug-tests-wk2/build/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 964, in _look_for_new_crash_logs
15:25:02.598 73067       writer.write_crash_log(crash_log)
15:25:02.598 73067     File "/Volumes/Data/slave/lion-debug-tests-wk2/build/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py", line 167, in write_crash_log
15:25:02.598 73067       self._write_text_file(filename, crash_log)
15:25:02.598 73067     File "/Volumes/Data/slave/lion-debug-tests-wk2/build/Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py", line 136, in _write_text_file
15:25:02.598 73067       self._filesystem.write_text_file(path, contents)
15:25:02.598 73067     File "/Volumes/Data/slave/lion-debug-tests-wk2/build/Tools/Scripts/webkitpy/common/system/filesystem.py", line 226, in write_text_file
15:25:02.598 73067       f.write(contents)
15:25:02.598 73067     File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 691, in write
15:25:02.599 73067       return self.writer.write(data)
15:25:02.599 73067     File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 351, in write
15:25:02.599 73067       data, consumed = self.encode(object, self.errors)
Failed to execute Tools/Scripts/new-run-webkit-tests at ./Tools/Scripts/run-webkit-tests line 124.
program finished with exit code 254

this problem (failure to write crash_log) seems to be fixable by the following patch:

diff --git a/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py b/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
index 0544918..dd19853 100644
--- a/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
+++ b/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
@@ -961,7 +961,7 @@ class Manager(object):
         if crash_logs:
             for test, crash_log in crash_logs.iteritems():
                 writer = TestResultWriter(self._port._filesystem, self._port, self._port.results_directory(), test)
-                writer.write_crash_log(crash_log)
+                writer.write_crash_log(unicode(crash_log))

     def _mark_interrupted_tests_as_skipped(self, result_summary):
         for test_name in self._test_files:

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.