[Webkit-unassigned] [Bug 91482] [GTK] No main resource in WebView on load committed when page has been loaded from history cache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91482





--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2012-07-28 04:40:21 PST ---
(From update of attachment 152725)
View in context: https://bugs.webkit.org/attachment.cgi?id=152725&action=review

Looks good overall. I wonder if it would make sense to fix this behavior in WebCore or WebKit2 instead though. Regardless, I have a few suggestions below.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1148
> +        // Finish a possible previous load waiting for main resource.
> +        webkitWebViewEmitDelayedLoadEvents(webView);

What sort of situation does WEBKIT_LOAD_STARTED happen without the main resource response happening? It might be good to specify this situation directly in this comment. Right now it answers the "What?" but not the "Why?"

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:1155
> +        setCertificateToMainResourceOrWait(webView);

I think it might be good to move

priv->waitingForMainResource = true;

to here and get rid of setCertificateToMainResourceOrWait. Right now it feels like it's a side-effect of setCertificateToMainResourceOrWait, while it affects more than just certificate handling (also emitting delayed loading events), so it's somewhat "hidden" away.

Also above that line I believe a comment explaining why we sometimes wait for the resource to load -- explaining the situation of back and forward with cached resources.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.