[Webkit-unassigned] [Bug 88094] Web Inspector: Add a WebInspectorServer on Linux using the GSocket API for the GTK port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=88094





--- Comment #9 from Gustavo Noronha (kov) <gns at gnome.org>  2012-07-28 04:02:00 PST ---
(In reply to comment #8)
> > This check seems unnecessary.
> 
> I'll remove it. By the way what is standard strategy in webkit to deal with failed memory allocations?

The only sane way to deal with it is to abort I think.

> > This doesn't look right... WebSocketServer::platform{Listen,Close} should already be called when appropriate, shouldn't they?
> 
> I don't think they are called, I need to check. Another reason was to start/stop the server if developer extras enabled/disabled via the menu.

If that's the case, we should probably be calling the WebSocketServer functions rather than doing work here, and there should be no reason to do it only for a port, I think.

> >> Source/WebKit2/UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:50
> >> +            url = "http://trac.webkit.org/export/head/trunk/Source/WebCore/inspector/front-end/inspector.html";
> > 
> > Hmm, no, we should use the locally installed file, not the one hosted in webkit.org.
> 
> The hosted one should have the latest updates/fixes, shouldn't it?

Yep. And it may be incompatible with the Inspector that is built in the library. Also, we don't want all users of WebKitGTK+ hitting a WebKit development server. And we don't want to require that the developer has an internet connection available for using the inspector. I can only see disadvantages for both the WebKit project and Inspector users.

> >> Source/WebKit2/UIProcess/InspectorServer/gtk/WebSocketServerGtk.cpp:87
> >> +        portValue = 2999;
> > 
> > Why 2999? Is it the same one used by the other ports?
> 
> well it was mentioned here as an example : http://www.webkit.org/blog/1620/webkit-remote-debugging/.
> Can be any value I suppose.

That sounds OK then. I hope we'll also add some API for starting the server, so a browser can do that even if it wasn't started with the env variable =).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.