[Webkit-unassigned] [Bug 92132] Add an overlay play button to media controls on android

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92132





--- Comment #20 from Min Qin <qinmin at chromium.org>  2012-07-28 01:06:41 PST ---
html/ happens to be one of the directory that *Android.cpp files are not excluded.  So that's why my android build works fine while the linux build is broken.

Updated the webcore.gyp file to exclude all the *Android.cpp files from html/ directory for non-android build.


(In reply to comment #18)
> This broke the Chromium-Linux canary compile.  Sample build log available at http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux%20%28dbg%29/builds/9510/steps/compile/logs/stdio .
> 
> The relevant info is:
> 
> out/Debug/../../third_party/gold/gold64: error: out/Debug/obj.target/third_party/WebKit/Source/WebCore/WebCore.gyp/libwebcore_html.a(out/Debug/obj.target/third_party/WebKit/Source/WebCore/WebCore.gyp/../../../../../webcore_html/third_party/WebKit/Source/WebCore/html/shadow/MediaControlRootElementChromiumAndroid.o): multiple definition of 'WebCore::MediaControls::create(WebCore::Document*)'
> out/Debug/../../third_party/gold/gold64: out/Debug/obj.target/third_party/WebKit/Source/WebCore/WebCore.gyp/libwebcore_html.a(out/Debug/obj.target/third_party/WebKit/Source/WebCore/WebCore.gyp/../../../../../webcore_html/third_party/WebKit/Source/WebCore/html/shadow/MediaControlRootElementChromium.o): previous definition here
> 
> Looks to me like the newly-added MediaControlRootElementChromiumAndroid.cpp file is not getting properly excluded from the Linux build.
> 
> Rolling this out on bug 92572.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.