[Webkit-unassigned] [Bug 92553] Add ENABLE_CSS_COMPOSITING flag

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 27 20:15:05 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=92553


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #155103|                            |review-
               Flag|                            |




--- Comment #7 from Dirk Schulze <krit at webkit.org>  2012-07-27 20:15:08 PST ---
(From update of attachment 155103)
You should not only remove the OOPS lines, but also add a comment what the change is about. I gave an example in my previous review: "Adds compiler flag CSS_COMPOSITING to build systems to enable CSS blending and compositing. See spec ...." See also http://www.webkit.org/coding/contributing.html for guidelines how to contribute patches. I still would like to see the flag added in other make files as well. Later it might be required to describe on every function listed in the ChangeLog what the change is about.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list