[Webkit-unassigned] [Bug 89692] Web Inspector: show worker started and finished on timeline

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89692





--- Comment #28 from Hanna <hanma at rim.com>  2012-07-27 12:21:29 PST ---
(From update of attachment 154987)
View in context: https://bugs.webkit.org/attachment.cgi?id=154987&action=review

>> Source/WebCore/ChangeLog:8
>> +        Test: inspector/timeline/timeline-web-workers.html
> 
> Please explain what happens and why.
> 
> I'd also be interested in learning more about the use cases. Is this a user request? There is a lot happening in the browser, not everything deserves to be on the timeline. Sorry for bringing it up so late, but I am sure you have some good answers to this. We do need to justify the code we are adding.

It is a user request

>> Source/WebCore/inspector/InspectorWorkerAgent.cpp:59
>> +        , m_id(id)
> 
> Please roll this back.

there will be instances where the browser don't have workerfrontend

>> Source/WebCore/inspector/InspectorWorkerAgent.cpp:196
>> +        createWorkerFrontendChannel(workerContextProxy, url.string(), WorkerFrontendChannel::s_nextId);
> 
> Wouldn't it be more elegant for createWorkerFrontendChannel to return channel's id?

the problem is not every browser has a worker frontend (as a matter of fact only chromium has it), idealy this thing has to work with all the browser

>> Source/WebCore/inspector/InspectorWorkerAgent.h:82
>> +    typedef HashMap<WorkerContextProxy*, std::pair<int, String> > DedicatedWorkers;
> 
> You don't need to change this map, do you?

I have to store id somewhere

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.