[Webkit-unassigned] [Bug 92515] New: [Chromium-Android] Virtual test suites fail

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92515

           Summary: [Chromium-Android] Virtual test suites fail
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Android
        OS/Version: Android
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: wangxianzhu at chromium.org
                CC: dpranke at chromium.org, peter at chromium.org


>From http://trac.webkit.org/changeset/122780 (bug 88542), ChromiumAndroidPort doesn't use DriverProxy but uses ChromiumAndroidDriver directly because we don't want DriverProxy to create two drivers for us. ChromiumAndroidDriver switches between pixel and non-pixel mode by itself.

However, the code to support virtual test suite is in DriverProxy, so now the feature is broken on Chromium-Android.

Dirk, can we move the following code from DriverProxy.run_test() into Driver.run_test()?

        base = self._port.lookup_virtual_test_base(driver_input.test_name)
        if base:
            virtual_driver_input = copy.copy(driver_input)
            virtual_driver_input.test_name = base
            virtual_driver_input.args = self._port.lookup_virtual_test_args(driver_input.test_name)
            return self.run_test(virtual_driver_input)

I tried that but it broke some unit tests. I'm wondering if the change would break some ports. If not, I could fix the unit tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.