[Webkit-unassigned] [Bug 92394] [Qt] Fix axis locking when panning on N9

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92394





--- Comment #2 from Andras Becsi <abecsi at webkit.org>  2012-07-27 02:15:05 PST ---
(From update of attachment 154714)
View in context: https://bugs.webkit.org/attachment.cgi?id=154714&action=review

Switching to the timestamp to calculate the elapsed time is a good idea.

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:227
> +    if (event->type() == QEvent::TouchBegin) {
> +        const QTouchEvent::TouchPoint& initialPoint = event->touchPoints().first();
> +        // Use screenPos as it'll be used to create synthetic MouseEvents
> +        setReferencePosition(initialPoint.screenPos());
> +        m_initialPosition = initialPoint.pos();
> +        m_time = event->timestamp();
> +        m_sampleCount = 0;
> +        return;
> +    }
>  
> -    if (m_sampleCount == 1) {
> -        m_initialScreenPosition = touchPoint.screenPos();
> -        m_time.restart();
> +    if (event->type() == QEvent::TouchEnd) {
> +        reset();
>          return;
>      }

Depending on TouchBegin and TouchEnd for axis locking does not seem right to me since a pan gesture might start with a TouchUpdate which has only one touch point (the previous update had multiple points -> transition from a pinch gesture) and it might end with a TouchUpdate when the event has multiple touch points (transition to a potential pinch gesture).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.