[Webkit-unassigned] [Bug 74040] Fails to build QtWebKit on QNX

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=74040


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #147345|review?                     |review-
               Flag|                            |




--- Comment #14 from Simon Hausmann <hausmann at webkit.org>  2012-07-27 01:53:49 PST ---
(From update of attachment 147345)
View in context: https://bugs.webkit.org/attachment.cgi?id=147345&action=review

This is going to need another iteration, I'm missing explanations (either in this bug or in the ChangeLog) as to why certain changes were made.

>> Source/WTF/wtf/DisallowCType.h:43
>> +#if !PLATFORM(QT) && !PLATFORM(WX) && !OS(QNX)
> 
> Add bug number?

Can you explain why you're moving the code block from config.h into this file?

> Source/WTF/wtf/Platform.h:493
> +#if OS(QNX) || PLATFORM(BLACKBERRY)
> +#define USE_SYSTEM_MALLOC 1
> +#endif

what's the difference between OS(QNX) and PLATFORM(BLACKBERRY)? Does the latter also include the non-QNX based blackberry platforms?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.