[Webkit-unassigned] [Bug 91581] [WK2][EFL] Add an ACCELERATED_COMPOSITING implementation for Efl WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91581





--- Comment #13 from YoungTaeck Song <youngtaeck.song at samsung.com>  2012-07-27 00:27:27 PST ---
(In reply to comment #11)
Thanks for kind review.

> (From update of attachment 154626 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154626&action=review
> 
> > Source/WebKit2/Shared/efl/LayerTreeContextEfl.cpp:2
> > +    Copyright (C) 2012 Samsung Electronics
> 
> I was told BSD license is more useful. So, could you change LGPL with BSD ?
fixed.
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:434
> > +    EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, 0);
> 
> Change 0 with false.
fixed.
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:435
> > +    EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, 0);
> 
> ditto.
fixed.
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:459
> > +    EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, 0);
> 
> ditto.
fixed.
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:460
> > +    EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, 0);
> 
> ditto.
fixed.
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:490
> > +    EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, 0);
> 
> ditto.
fixed.
> 
> > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:491
> > +    EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, 0);
> 
> ditto.
fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.