[Webkit-unassigned] [Bug 91956] [EFL] Change prototype of run_open_panel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91956





--- Comment #4 from Kihong Kwon <kihong.kwon at samsung.com>  2012-07-26 19:33:46 PST ---
(From update of attachment 154315)
View in context: https://bugs.webkit.org/attachment.cgi?id=154315&action=review

>> Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:487
>>          filenames.append((char*)filename);
> 
> I know this is not related to your patch but since you're touching this part of the code:
> We should probably use here: filenames.append(String::fromUTF8(static_cast<char*>(filename)));

OK, I will do that.

>> Source/WebKit/efl/ewk/ewk_view.h:191
>> +    Eina_Bool (*run_open_panel)(Ewk_View_Smart_Data *sd, Evas_Object *frame, Ewk_File_Chooser *file_chooser, Eina_List **selected_filenames);
> 
> Whenever you change this public smart class you must update EWK_VIEW_SMART_CLASS_VERSION below.

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.