[Webkit-unassigned] [Bug 91592] [EFL] Highlight the element under mouse on web inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91592


Kentaro Hara <haraken at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #154473|review?                     |review+
               Flag|                            |




--- Comment #14 from Kentaro Hara <haraken at chromium.org>  2012-07-26 18:21:12 PST ---
(From update of attachment 154473)
View in context: https://bugs.webkit.org/attachment.cgi?id=154473&action=review

Looks OK. rs=me

>>> Source/WebKit/efl/ewk/ewk_paint_context.cpp:181
>>> +        WebCore::InspectorController* controller = page->inspectorController();
>> 
>> I wonder if page always has inspector controller. If not, I think below condition is good to avoid crash.
>> 
>> if (WebCore::InspectorController* controller = page->inspectorController())
>>     if (controller->highlightedNode())
>>         controller->drawHighlight(*context->graphicContext);
> 
> It seems to me that page always has inspectorController.

Looks so to me too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.