[Webkit-unassigned] [Bug 91688] [chromium] Add CCScrollbarAnimationController class for compositor scrollbar animation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91688





--- Comment #5 from Tien-Ren Chen <trchen at chromium.org>  2012-07-26 17:28:30 PST ---
Also added a new test to verify scroll offsets are propagated properly.

(In reply to comment #3)
> (From update of attachment 153127 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=153127&action=review
> 
> This patch is great.  I really like the switch from pulling information from layers to pushing it there.
> 
> > Source/WebCore/page/FrameView.cpp:652
> > +#if OS(ANDROID)
> > +    if (m_frame->page()->mainFrame() == m_frame) {
> > +        if (hMode == ScrollbarAuto)
> > +            hMode = ScrollbarAlwaysOn;
> > +        if (vMode == ScrollbarAuto)
> > +            vMode = ScrollbarAlwaysOn;
> > +    }
> > +#endif
> 
> Is there a better place for this? How do other ports set the kind of scrollbars they want?

I also feel this might be too deep into WebCore... but seems like this is the only place we can override scrollbar visibility. :(

> > Source/WebCore/platform/graphics/chromium/cc/CCScrollbarAnimationControllerAndroid.h:34
> > +    CCScrollbarAnimationControllerAndroid(CCLayerImpl* scrollLayer);
> 
> 1-arg ctor needs the explicit keyword.  Can you also make a create function that returns a PassOwnPtr?

done

> > Source/WebCore/platform/graphics/chromium/cc/CCScrollbarAnimationControllerAndroid.h:40
> > +    virtual bool animate(double monotonicTime);
> > +    virtual void didPinchGestureUpdate();
> > +    virtual void didPinchGestureEnd();
> > +    virtual void updateScrollOffset(CCLayerImpl* scrollLayer);
> 
> OVERRIDE

done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.