[Webkit-unassigned] [Bug 92089] Web Inspector: Protocol Extension: Refactor protocol extension for CSS Regions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92089





--- Comment #4 from Andrei Poenaru <poenaru at adobe.com>  2012-07-26 10:21:17 PST ---
(In reply to comment #3)
> (From update of attachment 154641 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154641&action=review
> 
> Mostly looks good. My main concern is the temporary function.
> 
> > Source/WebCore/dom/WebKitNamedFlow.cpp:100
> > +const RenderRegionList* WebKitNamedFlow::tempGetRegions()
> 
> It sounds weird that we expose non-existing methods using the protocol.
> 
The team I am working in at Adobe is responsible with implementing CSS Regions in WebKit. The implementation of the "getRegions" method is in progress, but it may
take some time before it gets in WebKit: they are having a hard time finding a reviewer.
http://www.w3.org/TR/css3-regions/#the-namedflow-interface

> > Source/WebCore/inspector/Inspector.json:2166
> > +                    { "name": "regionOverset", "type": "string", "enum": ["overset", "fit", "empty"], "description": "The \"overset\" attribute of a Named Flow." },
> 
> this is already a region, consider dropping the "region" prefix.
> 
Because of the "overset" value of the enum the property can not be named the same.

> > Source/WebCore/inspector/Inspector.json:2178
> > +                    { "name": "overset", "type": "boolean", "description": "The \"overset\" attribute of a Named Flow." },
> 
> How do the overset properties of flow and the region correlate?
> 
The flow has "overset: true" if the last region in the region chain has "regionOverset: overset".

> > Source/WebCore/inspector/Inspector.json:2180
> > +                    { "name": "regions", "type": "array", "items": { "$ref": "Region" }, "description": "An array of regions associated with the Named Flow." }
> 
> contentNodeId.
> For my education: how do these two correlate? (content and regions.nodeIds).
> 
The content nodes are taken from the main document flow and flowed through the regions in DOM order.
Sample (css regions should be enabled in "about://flags"): http://adobe.github.com/web-platform/samples/css-regions/basic/single-flow.html

> > Source/WebCore/inspector/Inspector.json:2336
> > +                    { "name": "namedFlows", "type": "array", "items": { "$ref": "NamedFlow" }, "description": "An array containing the Named Flows in the document." }
> 
> You should remove getFlowByName now, right?
> 
The reason why I proposed this method is to avoid the overhead of requesting all named flows when one changes, or a new flow is created.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.