[Webkit-unassigned] [Bug 89666] [Qt] Separate WebKit2 instances use the same local storage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=89666





--- Comment #14 from Balazs Kelemen <kbalazs at webkit.org>  2012-07-26 02:30:40 PST ---
(From update of attachment 154367)
View in context: https://bugs.webkit.org/attachment.cgi?id=154367&action=review

LGTM with the need of some fix.

> Source/WebKit2/UIProcess/efl/WebContextEfl.cpp:52
> +    notImplemented();
> +    return "";

return String()

> Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp:51
> +    // FIXME: Implement
> +    return WTF::String();

I don't think you need WTF:: here.

> Source/WebKit2/UIProcess/mac/WebContextMac.mm:-91
> +    parameters.parentProcessName = [[NSProcessInfo processInfo] processName];
>  
>      NSURLCache *urlCache = [NSURLCache sharedURLCache];
> -
> -    parameters.parentProcessName = [[NSProcessInfo processInfo] processName];    
> -    parameters.nsURLCachePath = [(NSString *)cachePath.get() stringByStandardizingPath];

You don't need to move the assigment of parentProcessName, it just adds noise to the patch.

> Source/WebKit2/WebProcess/mac/WebProcessMac.mm:216
> -    appendReadwriteSandboxDirectory(sandboxParameters, "NSURL_CACHE_DIR", parameters.nsURLCachePath);
> +    appendReadwriteSandboxDirectory(sandboxParameters, "NSURL_CACHE_DIR", static_cast<NSString*>(parameters.diskCacheDirectory));

Do you need to cast to NSString* here? Isn't appendRead... a webkit function that get's a String?

> Source/WebKit2/WebProcess/mac/WebProcessMac.mm:264
> -    if (!parameters.nsURLCachePath.isNull()) {
> +    if (!static_cast<NSString*>(parameters.diskCacheDirectory).isNull()) {
>          NSUInteger cacheMemoryCapacity = parameters.nsURLCacheMemoryCapacity;
>          NSUInteger cacheDiskCapacity = parameters.nsURLCacheDiskCapacity;

You don't need the cast here.

> Tools/WebKitTestRunner/TestController.cpp:315
> +    // Can we remove it?
> +//    const char* path = libraryPathForTesting();
> +//    if (path) {
> +//        Vector<char> databaseDirectory(strlen(path) + strlen("/Databases") + 1);
> +//        sprintf(databaseDirectory.data(), "%s%s", path, "/Databases");
> +//        WKRetainPtr<WKStringRef> databaseDirectoryWK(AdoptWK, WKStringCreateWithUTF8CString(databaseDirectory.data()));
> +//        WKContextSetDatabaseDirectory(m_context.get(), databaseDirectoryWK.get());
> +//    }

I think we can. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.