[Webkit-unassigned] [Bug 91832] [EFL][WK2] Implemented color chooser proxy and input picker interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91832





--- Comment #16 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-07-25 23:08:29 PST ---
(From update of attachment 154474)
View in context: https://bugs.webkit.org/attachment.cgi?id=154474&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1102
> +    EINA_SAFETY_ON_NULL_RETURN(smartData->api->input_picker_show);

Don't you need to check if inputValue is null ?

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1122
> +    EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, EINA_FALSE);

Use standard boolean instead of EINA_FALSE.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1123
> +    EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, EINA_FALSE);

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1126
> +        return EINA_FALSE;

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1130
> +    return EINA_TRUE;

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1132
> +    return EINA_FALSE;

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1139
> +    EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, EINA_FALSE);

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1140
> +    EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, EINA_FALSE);

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1143
> +        return EINA_FALSE;

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1148
> +    return EINA_TRUE;

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1150
> +    return EINA_FALSE;

ditto.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:109
> +    Eina_Bool (*input_picker_show)(Ewk_View_Smart_Data *sd, Ewk_Input_Type input_type, const char *input_value);

Whenever you change this public smart class, you should update EWK_VIEW_SMART_CLASS_VERSION.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.