[Webkit-unassigned] [Bug 92237] [BlackBerry] Pass all file chooser settings to clients

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92237





--- Comment #4 from Robin Cao <robin.cao at torchmobile.com.cn>  2012-07-25 19:27:43 PST ---
(In reply to comment #3)
> (From update of attachment 154322 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154322&action=review
> 
> > Source/WebKit/blackberry/Api/WebPageClient.h:171
> > +    virtual bool chooseFilenames(bool allowMultiple, const SharedArray<WebString>& acceptTypes, unsigned numOfAcceptTypes, const SharedArray<WebString>& selectedFiles, unsigned numOfselectedFiles, const WebString& capture, SharedArray<WebString>& chosenFiles, unsigned& numOfChosenFiles) = 0;
> 
> Is it really needed to provide numOfAcceptTypes and numOfselectedFiles? Can't they be deduced from the SharedArrays?

I admit this method have too many parameters :(

SharedArray is a very simple template class in the platform. The array size cannot be deduced from SharedArray, since it does not store any information about the size of array.

I will look into if SharedArray can be extend so that we can get array size from it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.