[Webkit-unassigned] [Bug 92213] [EFL][WK2] Implement the inspector for WebKitTestRunner

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=92213





--- Comment #3 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-07-25 18:02:48 PST ---
(From update of attachment 154297)
View in context: https://bugs.webkit.org/attachment.cgi?id=154297&action=review

> Source/WebKit2/ChangeLog:8
> +        Partial Implementation of WebInspectorProxyEfl for WebkitTestRunner

Missing '.' at the end of sentence.

> Source/WebKit2/UIProcess/WebInspectorProxy.cpp:86
> +#elif PLATFORM(EFL)

I think we don't need to have independent #elif because variable names are same.

> Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp:94
> +    if (access(inspectorFilesPath.utf8().data(), R_OK)) // On success, zero is returned

Unneeded comment. Everyone know zero is returned on success.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.