[Webkit-unassigned] [Bug 91832] [EFL][WK2] Implemented color chooser proxy and input picker interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91832


Ryuan Choi <ryuan.choi at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ryuan.choi at samsung.com




--- Comment #14 from Ryuan Choi <ryuan.choi at samsung.com>  2012-07-25 16:02:53 PST ---
(In reply to comment #13)
> (From update of attachment 154310 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=154310&action=review
> 
> >> Source/WebKit2/UIProcess/API/efl/InputPicker.h:35
> >> +class InputPicker {
> > 
> > I don't have idea how to implement input picker because we can not use elementary and edj approach is too expensive.
> > 
> > So,  exposing interface as member of smart class looks enough to me.
> 
> I agree with you. I'll remove this.
> 
> >> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:1146
> >> +    return EINA_FALSE;
> > 
> > macro is wrong.
> > 
> > And remove // ...
> 
> Can you explain why it's wrong?

Sure, when enabled INPUT_TYPE_COLOR, this function have two return statement.
Although compile ignore last one, he probably complain it as warning.

> 
> And "//" is used in many places.
I don't know whether we have rules for this.
But, I believe that "// ENABLE(XXX)" is used to reduce confusion from big fence of macro or overlapped macro.

IMO, this is not necessary and bad with readibility for the small guard.

> 
> >> Source/WebKit2/UIProcess/API/efl/ewk_view.h:75
> >> +    EWK_INPUT_TYPE_TELEPHONE = 1, 
> > 
> > I am not sure. but webkit does not use = 1 for enum.
> > 
> > please check whether I am right.
> 
> It can be used, I think.
> 
> enum AccessibilityRole {
>     AnnotationRole = 1,
>     ApplicationRole,
>     ApplicationAlertRole,

OK if then, I don't have objection for this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.