[Webkit-unassigned] [Bug 91832] [EFL][WK2] Implemented color chooser proxy and input picker interface

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91832


KwangYong Choi <ky0.choi at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #154272|0                           |1
        is obsolete|                            |
 Attachment #154272|review?, commit-queue?      |
               Flag|                            |




--- Comment #8 from KwangYong Choi <ky0.choi at samsung.com>  2012-07-25 02:50:32 PST ---
Created an attachment (id=154305)
 --> (https://bugs.webkit.org/attachment.cgi?id=154305&action=review)
Patch

1. Changed bug title.

2. Moved member variables to proper position.

3. Removed priv->inputPicker = nullptr;

4. Moved "*" to proper position and changed variable names.

5. Moved allocation of InputPicker routine to Ewk_View_Private_Data constructor.

6. Made early return.

7. ewk_view_color_chooser_color_set() function accepts all color formats webkit can recognize. For example, named color can be used. So, I removed color format example.

8. The initial value is passed when the InputPicker::show() is called. After that, UI can change values and sets the value user choose. I think the function to get the value is not necessary right now.

9. Added Eina_Bool return type for external api functions.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.