[Webkit-unassigned] [Bug 91832] [EFL][WK2] Implement color chooser interface for EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=91832





--- Comment #4 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-07-24 23:09:19 PST ---
(From update of attachment 154248)
View in context: https://bugs.webkit.org/attachment.cgi?id=154248&action=review

> Source/WebKit2/UIProcess/API/efl/InputPicker.cpp:4
> + * Redistribution and use in source and binary forms, with or without

I'm checking which license we use. So, I don't know which license is best for us.

> Source/WebKit2/UIProcess/API/efl/InputPicker.h:37
> +    InputPicker(Evas_Object*);

Use *explicit* keyword.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:87
> +typedef enum _Ewk_Input_Type Ewk_Input_Type;

Please add below comment for above type definition.

/** Creates a type name for _Ewk_Input_Type_Ewk_Input_Type */

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:472
> +EAPI void ewk_view_color_chooser_color_set(Evas_Object* o, const char* color);

Nit: Move '*' to variable side.

> Source/WebKit2/UIProcess/API/efl/ewk_view.h:479
> +EAPI void ewk_view_color_chooser_close(Evas_Object* o);

ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.