[Webkit-unassigned] [Bug 91351] [EFL][WK2] Add ewk_view_user_agent_set / ewk_view_user_agent_get API.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 24 18:47:41 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=91351





--- Comment #29 from Ryuan Choi <ryuan.choi at samsung.com>  2012-07-24 18:47:45 PST ---
(From update of attachment 152929)
View in context: https://bugs.webkit.org/attachment.cgi?id=152929&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:984
> +        WKPageSetCustomUserAgent(toAPI(priv->pageClient->page()), 0);
> +    } else {
> +        if (eina_stringshare_replace(&priv->userAgent, userAgent)) {
> +            WKRetainPtr<WKStringRef> userAgentString(AdoptWK, WKStringCreateWithUTF8CString(userAgent));
> +            WKPageSetCustomUserAgent(toAPI(priv->pageClient->page()), userAgentString.get());
> +        }
> +    }

Personally, I preferred early return without else.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list