[Webkit-unassigned] [Bug 92184] [chromium] Move renderingStats from WebView to WebWidget.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 24 18:04:45 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=92184


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #154194|review?                     |review+
               Flag|                            |




--- Comment #3 from Adam Barth <abarth at webkit.org>  2012-07-24 18:04:48 PST ---
(From update of attachment 154194)
View in context: https://bugs.webkit.org/attachment.cgi?id=154194&action=review

> Source/WebKit/chromium/public/WebWidget.h:226
> +    // Fills in a WebRenderingStats struct containing information about the state of the compositor.
> +    // This call is relatively expensive in threaded mode as it blocks on the compositor thread.

This comment seems slightly at odds with the ChangeLog.

This patch is fine, but it would be valuable to add some more information to the ChangeLog about why we're making this change.  Maybe just an example?  Certainly not a big deal, but it can be helpful to folks reading these patches.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list