[Webkit-unassigned] [Bug 92176] Remove unused function in InjectedBundleHitTestResult

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 24 18:02:16 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=92176





--- Comment #11 from Brady Eidson <beidson at apple.com>  2012-07-24 18:02:20 PST ---
(In reply to comment #10)
> (In reply to comment #9)
> > Is there any particular reason we're doing this?  We don't normally go on cleanup tasks like this just for the heck of it.
> 
> It was first appeared at 39e1fcbcf3dbb10eaa79d6364a43d781b3d9ebee(Sat Sep 25 02:32:56 2010).
> 
> But it is remained as dead code. 
> WKBundleHitTestResult is API level of InjectedBundleHitTestResult. But API level does not have any match case.
> 
> Also it seems to be redundant with another member function "static PassRefPtr<InjectedBundleHitTestResult> create(const WebCore::HitTestResult&)"


I understand that it is dead code and unused.

My point is that we don't normally go on tiny little cleanup tasks like this.  It uses up buildbot infrastructure and reviewer time as well as causes potential merging problems for various branches and ports.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list